Cleanup workflows (#148)

* Workflows: remove default input arg from action call Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * workflows: Remove unnecessary selftest release-signing-artifacts defaults to "true" so the removed test now duplicates the previous test. We could try testing the release-signing-artifacts == "false" but that's a bit trickier since it could only be done in a release event... Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * workflows: Drop recently removed job from needs-list Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
sigstore · Jul 9, 2024 · da238ad · da238ad
1 parent 551a497
commit da238ad
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 31 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -23,4 +23,3 @@ jobs:
         id: sigstore-python
         with:
           inputs: action.yml action.py
-          release-signing-artifacts: true
diff --git a/.github/workflows/selftest.yml b/.github/workflows/selftest.yml
@@ -93,35 +93,6 @@ jobs:
           [[ -f ./test/white\ space.txt ]] || exit 1
           [[ -f ./test/more\ white\ space.txt ]] || exit 1
 
-  selftest-release-signing-artifacts-no-op:
-    strategy:
-      matrix:
-        os:
-          - ubuntu-latest
-          - macos-latest
-          - windows-latest
-    runs-on: ${{ matrix.os }}
-    if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        if: ${{ matrix.os != 'ubuntu-latest' }}
-        with:
-          python-version: "3.x"
-      - name: Sign artifact and publish signature
-        uses: ./
-        id: sigstore-python
-        with:
-          inputs: ./test/artifact.txt
-          # The trigger for this test is not a release, so this has no effect
-          # (but does not break the workflow either).
-          release-signing-artifacts: true
-          internal-be-careful-debug: true
-      - name: Check outputs
-        shell: bash
-        run: |
-          [[ -f ./test/artifact.txt.sigstore.json ]] || exit 1
-
   selftest-xfail-invalid-inputs:
     runs-on: ubuntu-latest
     strategy:
@@ -349,7 +320,6 @@ jobs:
     needs:
       - selftest
       - selftest-whitespace
-      - selftest-release-signing-artifacts-no-op
       - selftest-xfail-invalid-inputs
       - selftest-staging
       - selftest-glob