Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to sign for the default release assets #44

Closed
woodruffw opened this issue Feb 9, 2023 · 2 comments · Fixed by #46
Closed

Figure out how to sign for the default release assets #44

woodruffw opened this issue Feb 9, 2023 · 2 comments · Fixed by #46
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

By default, GitHub Actions produces {tag}.tar.gz and {tag}.zip assets for each release.

These artifacts are generated on the fly, meaning that they can (and have) changed their contents (and thus digests) over time. This recently caused some significant breakage due to incorrect assumptions around that: https://github.blog/changelog/2023-01-30-git-archive-checksums-may-change/

Given that they can change, the correct thing for us to do here is probably to download the asset as it appears, sign for it, and then re-upload it to the release as a new asset: this will freeze it, meaning that the signature will remain correct.

@woodruffw woodruffw added the enhancement New feature or request label Feb 9, 2023
@woodruffw
Copy link
Member Author

So, the individual items here:

  1. Figure out how to download the "special" {tag}.tar.gz and {tag}.zip assets from a workflow that was triggered by the release: published event;
  2. Sign for them;
  3. Upload them back to the release, along with their signatures.

@woodruffw
Copy link
Member Author

CC @tnytown: I can't assign you this since you're not an org member, but this is a good first issue to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant