Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctlog is missing a dependency on trillian #617

Open
mattmoor opened this issue Sep 30, 2023 · 2 comments
Open

ctlog is missing a dependency on trillian #617

mattmoor opened this issue Sep 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Member

mattmoor commented Sep 30, 2023

Description

I noticed that the Rekor chart spins up Trillian, but the ctlog chart does not.

Rekor has the following:

dependencies:
- name: trillian
version: 0.2.12
repository: https://sigstore.github.io/helm-charts
condition: trillian.enabled

However, I don't see the same in the ctlog chart: https://github.com/sigstore/helm-charts/blob/main/charts/ctlog/Chart.yaml

Version

HEAD

@mattmoor mattmoor added the bug Something isn't working label Sep 30, 2023
@bobcallaway
Copy link
Member

@vaikas was this a deliberate decision re: ctlog sharding work?

@vaikas
Copy link
Contributor

vaikas commented Oct 26, 2023

I honestly don't know because I didn't write these :) I would assume that ctlog should have a dependency on trillian, and it would just get configured differently, but maybe that's where the concern of taking a dependency on it here is and which trillian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants