Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding custom labels to the deployment policy controller #658

Open
CodeGlitcher opened this issue Nov 21, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@CodeGlitcher
Copy link

CodeGlitcher commented Nov 21, 2023

Description

Support added custom labels to the webhook deployment for hte policy controller

In our project we use NetworkPolicies to limit what applications are allowed to access.
For the network policies we have created custom labels to select where they apply:
like: egress-kube-system-api-server

Could the helm chart support a variable like extraLabels
to add additional labels to the deployment?

@CodeGlitcher CodeGlitcher added the enhancement New feature or request label Nov 21, 2023
@CodeGlitcher CodeGlitcher changed the title Support adding custom labels to the deployment. Support adding custom labels to the deployment policy controller Nov 21, 2023
@hectorj2f
Copy link
Contributor

@CodeGlitcher
Copy link
Author

I dont think so.
policy-controller.labels are defined in the helm __helpers
As far as I know you cannot override these from the values.yaml

{{/*
Common labels
*/}}
{{- define "policy-controller.labels" -}}
helm.sh/chart: {{ include "policy-controller.chart" . }}
{{ include "policy-controller.selectorLabels" . }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- end }}

also these labels are added to the deployment and not the actual pod.

@hectorj2f
Copy link
Contributor

Yes, you're right. Let me fix that in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants