Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify updating dependencies #43

Closed
mihaimaruseac opened this issue Oct 24, 2023 · 0 comments · Fixed by #45
Closed

Simplify updating dependencies #43

mihaimaruseac opened this issue Oct 24, 2023 · 0 comments · Fixed by #45

Comments

@mihaimaruseac
Copy link
Collaborator

In #30, we bumped actions.setup-python but then this caused issues when installing the dependencies as now some hashes were missing. So we had to revert in #42.

In #37 we only have a bump in cryptography but that results in incompatible dependency set

INFO: pip is looking at multiple versions of pyopenssl to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install -r model_signing/install/requirements.txt (line 350) and cryptography==41.0.4 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested cryptography==41.0.4
    pyopenssl 23.0.0 depends on cryptography<40 and >=38.0.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

We will probably need 2 things:

  • one workflow that just tries to install the dependencies on PRs so we quickly receive signals when something breaks (at least until we get real unit tests)
  • a modality to quickly update the lock files

We probably also need to further debug the #31 / #42 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant