Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to objects admitted by policy-controller #611

Open
jkjell opened this issue Feb 23, 2023 · 5 comments · May be fixed by #732
Open

Add annotations to objects admitted by policy-controller #611

jkjell opened this issue Feb 23, 2023 · 5 comments · May be fixed by #732
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jkjell
Copy link

jkjell commented Feb 23, 2023

Description

It would be awesome to see the results of policy-controller admissions recorded on affected objects.

There's a great example from Tekton Chains where they record helpful metadata:

kubectl get tr [TASKRUN_NAME] -o json | jq -r .metadata.annotations

{
  "chains.tekton.dev/signed": "true",
  ...
}

The things that seem most useful to me from the policy-controller side would be an annotation referencing the admitting or denying policy, the status, and ideally, enough details to understand the reasoning behind the policy decision.

@jkjell jkjell added the enhancement New feature or request label Feb 23, 2023
@hectorj2f hectorj2f added this to the v1 milestone Mar 1, 2023
@elfotografo007
Copy link
Contributor

I can take care of this one. What is our timeline for v1?

@hectorj2f
Copy link
Collaborator

@elfotografo007 We don't have a defined timeline yet.

@hectorj2f
Copy link
Collaborator

Feel free to assign it to yourself whenever you start working on this.

@elfotografo007
Copy link
Contributor

I don't have the right to assign it to me. Can you assign it?

@hectorj2f
Copy link
Collaborator

@elfotografo007 Done 👍!

@elfotografo007 elfotografo007 linked a pull request Apr 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants