Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --file-ca (or something flag) for taking in secret from files like Fulcio does. #1026

Closed
vaikas opened this issue Sep 6, 2022 · 1 comment · Fixed by #1049
Closed
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Sep 6, 2022

Description

Currently Rekor has an ephemeral signer mode here:
https://github.com/sigstore/rekor/blob/main/cmd/rekor-server/app/root.go#L76

This works mostly fine, but with us moving to TUF everywhere (and getting rid of various env flags for specifying public keys) if Rekor ever restarts during the testing this will create a new in-mem public key and hence the TUF root doesn't work. Fulcio has a way to specify a file_ca:
https://github.com/sigstore/fulcio/blob/main/cmd/app/serve.go#L69

We talked about this in the Slack and agreed this would be useful to do, we just need to mark the flag clearly that it's used for testing.

https://sigstore.slack.com/archives/C01CX4E2K70/p1659553415708999

@asraa

@vaikas vaikas added the enhancement New feature or request label Sep 6, 2022
@asraa
Copy link
Contributor

asraa commented Sep 6, 2022

@cdris do you think you might have time to take this? It would be like --filesigner-key to hold an encrypted key on file (Rekor doesn't need a whole signing cert)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants