Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client libraries should verify after signing #745

Open
znewman01 opened this issue Sep 5, 2023 · 1 comment
Open

Client libraries should verify after signing #745

znewman01 opened this issue Sep 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@znewman01
Copy link

In the Sigstore clients special interest group meeting today, we discussed an issue with the release signatures on CPython.

We have two recommendations for client libraries:

  1. After signing, the clients MUST verify the signature (see Sigstore client spec). 2.
  2. Client library interfaces SHOULD allow callers to specify an identity (and other verification parameters) to use for this verification.

I'm going to be a bit lazy (sorry) and rather than inspecting every client library by hand, just ask whether you're doing the these and, if not, whether you all agree with these recommendations.

@znewman01 znewman01 added the bug Something isn't working label Sep 5, 2023
@bdehamer
Copy link
Collaborator

bdehamer commented Sep 8, 2023

Currently, sigstore-js does neither of these things. However, I agree with the recommendations.

I'm working on refactoring a lot of the verification logic and will be sure to incorporate these requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants