Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigstore bundle support #280

Open
woodruffw opened this issue Jun 20, 2023 · 7 comments
Open

Sigstore bundle support #280

woodruffw opened this issue Jun 20, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

Description

As identified in #274: this client should support the bundle format defined in protobuf-specs for both signing and verification!

This will also unblock integration with the conformance suite, which tests for bundle support.

It looks like https://docs.rs/protobuf/latest/protobuf/ is the most mature protobuf library for Rust, so we'll probably want to go with that.

@woodruffw woodruffw added the enhancement New feature or request label Jun 20, 2023
@woodruffw
Copy link
Member Author

CC @jleightcap

@woodruffw
Copy link
Member Author

This may be blocked on #83 -- @lkatalin or @lukehinds might have some more details 🙂

@lukehinds
Copy link
Member

lukehinds commented Jun 27, 2023

@woodruffw I don't think there is anything more to update since that was raised. It should not be hard to implement though (verify locally). I am absolutely slammed out with other stuff at the moment, not sure if @lkatalin has any cycles to take this on. I will add it to my tracking notes though as getting sigstore-rs protobuf aligned would be definite a step forwards.

@woodruffw
Copy link
Member Author

Okay, thanks for the update @lukehinds! I've asked @jleightcap to take a look at this.

@jleightcap
Copy link
Contributor

Thanks, now in progress -- I'll add comments/questions to this issue as I get further.

@jleightcap
Copy link
Contributor

CC @tnytown

@tnytown
Copy link
Contributor

tnytown commented Sep 27, 2023

As part of this work, I took another look at the client's certificate validation logic. It looks like both webpki and picky were considered for validation as part of #32, but webpki was dropped as it didn't support checking EKUs against custom non-TLS profiles at the time. Now that rustls/webpki has implemented a new verify_is_valid_cert, I'll refactor the validation logic with webpki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants