Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityToken: Only "email" identity is supported #413

Open
jku opened this issue Oct 22, 2024 · 0 comments · May be fixed by #412
Open

IdentityToken: Only "email" identity is supported #413

jku opened this issue Oct 22, 2024 · 0 comments · May be fixed by #412

Comments

@jku
Copy link
Member

jku commented Oct 22, 2024

oauth::IdentityToken always uses "email" as the identity of the token -- but some oidc issuers, like GitHub Actions, use "sub" as the identity and Fulcio does supports that...

  • tokens with "sub" identity should be supported (and in fact this should likely be default): Currently they fail to parse
  • signing and verification should be possible with "sub" identities, so issuers like GitHub Actions can be used

See also #409

I'll try fixing at least the first issue in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant