Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliancy the default metrics with Prometheus Naming Convention #283

Open
izonder opened this issue Aug 27, 2019 · 2 comments · May be fixed by #284
Open

Compliancy the default metrics with Prometheus Naming Convention #283

izonder opened this issue Aug 27, 2019 · 2 comments · May be fixed by #284
Labels
good first issue help wanted

Comments

@izonder
Copy link

izonder commented Aug 27, 2019

Checking the default metrics with promtool complains about breaking compliancy with official Prometheus Naming Convention (https://prometheus.io/docs/practices/naming/), e.g.:

$ curl -s http://localhost:3000/metrics | promtool check metrics
nodejs_active_handles_total non-counter metrics should not have "_total" suffix
nodejs_active_requests_total non-counter metrics should not have "_total" suffix
@SimenB
Copy link
Collaborator

SimenB commented Aug 27, 2019

PR very much welcome fixing all metric names!

@izonder izonder linked a pull request Aug 27, 2019 that will close this issue
Open
@izonder
Copy link
Author

izonder commented Aug 29, 2019

@SimenB please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: align compliancy to Prometheus naming convention izonder/prom-client
2 participants
@SimenB @izonder