Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section titles in running header are conditioned by folios (book class) #1291

Open
Omikhleia opened this issue Nov 23, 2021 · 2 comments
Open
Labels
bug Software bug issue

Comments

@Omikhleia
Copy link
Member

Seen "in passing" while fixing #1276 : In the book class, for the "section" command, having the section title in the running header is currently (SILE 0.12) conditioned by not having folios disabled...

  if not SILE.scratch.counters.folio.off then
    SILE.call("right-running-head", {}, function ()
      SILE.call("book:right-running-head-font")
...

IMHO, there shouldn't be such a relation between two decisions that should be independent (having running headers != having page folios). Removing that above-mentioned check without taking any other action would however be a breaking changes: the book class currently disables folios on chapter pages - so currently this behavior is what ensures having neither folios nor section titles on chapter pages (e.g. in the SILE manual)...

FWIW, my own approach to it in my own class implementation is to have noheaders, noheaderthispage etc. in a way similar to the folios, so the decision can be made wholly independent (https://github.com/Omikhleia/omikhleia-sile-packages/blob/main/packages/omiheaders.lua) - one reason being that I do want to be able to get page numbers on chapter pages ;-)

@Omikhleia Omikhleia added the bug Software bug issue label Mar 26, 2023
@jodros
Copy link
Contributor

jodros commented Feb 6, 2024

I guess I didn't get it despite looking too simple, like, why isn't it just a matter of removing the if?

@Omikhleia
Copy link
Member Author

Because a book class must be able do disable headers on some pages (typically chapter pages):

Removing that above-mentioned check without taking any other action would however be a breaking changes: the book class currently disables folios on chapter pages

Which is legit in most conventions,

But it also needs to be able to disable page folio on some pages too.
However the functionally should be orthogonal decisions, as they depend on conventions (and book types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
Status: To Do
Development

No branches or pull requests

2 participants