Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation error #7

Closed
nkrylov opened this issue Nov 29, 2021 · 3 comments · Fixed by #8
Closed

compilation error #7

nkrylov opened this issue Nov 29, 2021 · 3 comments · Fixed by #8

Comments

@nkrylov
Copy link

nkrylov commented Nov 29, 2021

https://github.com/sile/efmt/blob/master/rebar3_efmt/src/rebar3_efmt_command.erl#L59 this line causes compilation error
@sile
Copy link
Owner

sile commented Nov 29, 2021

Thank you for reporting this issue.
As L59 uses the "Numeric literals with underscore" feature introduced by OTP-23, Erlang/OTP releases older than that will raise a compilation error.
However, there is no strong reason to use the relatively new feature in the file. I'm going to fix the file soon.

@sile sile mentioned this issue Nov 29, 2021
Merged
@nkrylov
Copy link
Author

nkrylov commented Nov 29, 2021

@sile didn't know they exist, thanks for the link!

@sile sile closed this as completed in #8 Nov 29, 2021
@sile
Copy link
Owner

sile commented Nov 29, 2021

Fixed and published v0.1.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using "Numeric literals with underscore" feature sile/efmt
2 participants
@sile @nkrylov