Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile on stable rust version #23

Closed
TheAifam5 opened this issue Aug 28, 2019 · 3 comments
Closed

Unable to compile on stable rust version #23

TheAifam5 opened this issue Aug 28, 2019 · 3 comments

Comments

@TheAifam5
Copy link

TheAifam5 commented Aug 28, 2019

Hey!

I am unable to use that package because of an issue in kvfilter. Is there any workaround for that?

Environment:
rustup 1.18.3 (2019-05-23)
rustc 1.37.0 (eae3437df 2019-08-13)

Related issue:
slog-rs/kvfilter#17

Regards,
TheAifam5

@sile
Copy link
Owner

sile commented Aug 31, 2019

Thank you for reporting this issue.

I tried to reproduce this problem, but I couldn't do it (i.e., the compilation was succeeded).
The following commands are the log:

$ uname -a
Linux foo 4.4.0-17763-Microsoft #379-Microsoft Wed Mar 06 19:16:00 PST 2019 x86_64 GNU/Linux

$ rustc --version
rustc 1.37.0 (eae3437df 2019-08-13)

$ git clone git@github.com:sile/sloggers.git
$ cd sloggers

$ git rev-parse HEAD
1c69037728ff256a21d7b73e867e379c85cd75e3

$ cargo update
$ cargo build
   Compiling autocfg v0.1.6
   Compiling proc-macro2 v0.4.30
   Compiling unicode-xid v0.1.0
   Compiling libc v0.2.62
   Compiling proc-macro2 v1.0.1
   Compiling memchr v2.2.1
   Compiling syn v0.15.44
   Compiling byteorder v1.3.2
   Compiling slog v2.5.2
   Compiling log v0.4.8
   Compiling unicode-xid v0.2.0
   Compiling lazy_static v1.4.0
   Compiling syn v1.0.5
   Compiling crc32fast v1.2.0
   Compiling cfg-if v0.1.9
   Compiling arc-swap v0.3.11
   Compiling serde v1.0.99
   Compiling regex-syntax v0.6.11
   Compiling take_mut v0.2.2
   Compiling crossbeam v0.2.12
   Compiling rle-decode-fast v1.0.1
   Compiling adler32 v1.0.3
   Compiling thread_local v0.3.6
   Compiling num-traits v0.2.8
   Compiling num-integer v0.1.41
   Compiling log v0.3.9
   Compiling slog-scope v4.1.2
   Compiling slog-async v2.3.0
   Compiling time v0.1.42
   Compiling dirs v1.0.5
   Compiling atty v0.2.13
   Compiling aho-corasick v0.7.6
   Compiling libflate v0.1.27
   Compiling quote v0.6.13
   Compiling quote v1.0.2
   Compiling slog-stdlog v3.0.5
   Compiling term v0.5.2
   Compiling chrono v0.4.7
   Compiling regex v1.2.1
   Compiling slog-term v2.4.1
   Compiling serde_derive v1.0.99
   Compiling slog-kvfilter v0.7.0
   Compiling trackable_derive v0.1.2
   Compiling trackable v0.2.23
   Compiling sloggers v0.3.3 (/tmp/sloggers)
    Finished dev [unoptimized + debuginfo] target(s) in 46.90s

Could you tell me more information about your environment?

@TheAifam5
Copy link
Author

That issue is related to this: slog-rs/kvfilter#17
while compiling with dynamic-keys feature.

@sile
Copy link
Owner

sile commented Sep 8, 2019

I see. Thank you for your information.
I made slog-kvfilter an optional feature and added it to the default feature list of sloggers.
By using sloggers after v0.3.4, you can disable slog-kvfilter as follows:

# Cargo.toml
[package]
name = "slog-test"
version = "0.1.0"
edition = "2018"

[dependencies]
slog = {version="2", features=["dynamic-keys"]}
sloggers = {version="0.3", default-features=false}  # disable default features (i.e., slog-kvfilter)

@sile sile closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants