Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong(?) field name in MagicStrings.cs #109

Open
rmunn opened this issue May 5, 2021 · 1 comment · May be fixed by #110
Open

Wrong(?) field name in MagicStrings.cs #109

rmunn opened this issue May 5, 2021 · 1 comment · May be fixed by #110
Assignees
@josephmyers

Comments

@rmunn
Copy link
Collaborator

rmunn commented May 5, 2021

One magic string in MagicStrings.cs is LfFieldNameForExampleSentence = "definition", and that should probably be "sentence" or "example". I'll have to check the Language Forge code to be sure which one it is.
@rmunn rmunn mentioned this issue May 5, 2021
Merged
@megahirt megahirt linked a pull request May 5, 2021 that will close this issue
Open
@megahirt
Copy link
Contributor

@josephmyers this looks like a typo in our code. We need to verify it really is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephmyers josephmyers

Labels
None yet
Projects
Language Forge Classic
Status: To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(On hold) Bugfix: Correct example sentence magic string sillsdev/LfMerge
3 participants
@rmunn @megahirt @josephmyers