Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project export name is randomized, not the name given in the backend. #646

Closed
imnasnainaec opened this issue Aug 25, 2020 · 2 comments · Fixed by #800
Closed

Project export name is randomized, not the name given in the backend. #646

imnasnainaec opened this issue Aug 25, 2020 · 2 comments · Fixed by #800
Assignees
@imnasnainaec
Labels
import/export

Comments

@imnasnainaec
Copy link
Collaborator

#638 used URL.createObjectURL() to create a frontend url for downloading the file (https://github.com/sillsdev/TheCombine/blob/master/src/components/ProjectSettings/ProjectExport/ExportProjectButton.tsx#L29), so the informative filename created in the backend (https://github.com/sillsdev/TheCombine/blob/master/Backend/Services/LiftApiServices.cs#L242-L243) is lost.
@imnasnainaec
Copy link
Collaborator Author

Related: #596

@imnasnainaec
Copy link
Collaborator Author

imnasnainaec commented Nov 4, 2020 •
edited
Loading

Related: #799 (https://www.w3schools.com/tags/att_a_download.asp)

@imnasnainaec imnasnainaec self-assigned this Nov 4, 2020
@imnasnainaec imnasnainaec mentioned this issue Nov 4, 2020
Merged
@imnasnainaec imnasnainaec mentioned this issue Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imnasnainaec imnasnainaec

Labels
import/export
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project export filename projectName_date_time sillsdev/TheCombine
1 participant
@imnasnainaec