Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokenizer to accept new characters for Huggingface models #20

Closed
johnml1135 opened this issue Jul 18, 2023 · 1 comment · Fixed by #43
Closed

Update tokenizer to accept new characters for Huggingface models #20

johnml1135 opened this issue Jul 18, 2023 · 1 comment · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@johnml1135
Copy link
Collaborator

Related to the effort here: sillsdev/silnlp#171

@johnml1135 johnml1135 added the enhancement New feature or request label Jul 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Jul 18, 2023
@johnml1135 johnml1135 moved this from 🆕 New to 📋 Backlog in Serval Jul 18, 2023
@johnml1135 johnml1135 added this to the Mother Tongue MVP milestone Jul 19, 2023
@johnml1135 johnml1135 moved this from 📋 Backlog to 🏗 In progress in Serval Jul 19, 2023
@johnml1135
Copy link
Collaborator Author

This is to add new characters to NLLB 200 to enable both random one-off characters and entirely new scripts. Current status:

Things to do:

  • Check if freezing the model and adding another layer helps with Blue score, especially with new scripts as in this threadthub thread
  • Implement in Machine.py with some testing
  • Add basic controls through YAML files for enabling, size of vocab, etc.

@mshannon-sil mshannon-sil linked a pull request Oct 13, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Serval Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants