Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Languages before uploading #710

Open
peteroatley opened this issue Sep 5, 2024 · 5 comments
Open

Delete Languages before uploading #710

peteroatley opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@peteroatley
Copy link
Collaborator

peteroatley commented Sep 5, 2024

Some websites have a problem with duplicated names in the language dropdown on the search page.

Image

The cause of the problem isn't known but it could be to do with changes to the analysis languages in FLEx after the dictionary is first uploaded. It would be helpful to delete the language information when the dictionary is uploaded so that old information is not retained.

There is the possibility that the site owner has modified the language information on Webonary but we will wait and see if that is a problem.

The language information is found under Pages-> languages.

The problem can be solved by deleting the incorrect language but it isn't always easy to tell which languages need to be removed.

@peteroatley peteroatley converted this from a draft issue Sep 5, 2024
@peteroatley peteroatley added the bug Something isn't working label Sep 5, 2024
@phillip-hopper phillip-hopper self-assigned this Nov 14, 2024
@phillip-hopper
Copy link
Collaborator

@peteroatley, the list of languages is not the "reversal" languages. In addition the the vernacular language, it contains the "definition or gloss languages". I'm not sure how that is compiled, but my first guess is that it is the language codes found in the data.

@peteroatley
Copy link
Collaborator Author

@phillip-hopper I test uploading and the languages are deleted which is great but for English the name of the reversal index has been used instead of the language name:
Image

Can this be changed?

@phillip-hopper
Copy link
Collaborator

@peteroatley, I believe the only alternative to using the reversal name is to try to guess the name from the language code, like we are now doing for the analysis languages.

@peteroatley
Copy link
Collaborator Author

In the example above English and Spanish are the analysis languages and French is the vernacular language. I think it would be better to use the language code but we'll have to see how that works. Some dictionaries don't have a reversal index so using the language code is probably more reliable in some ways. I think we need FLEx to upload the vernacular and analysis language information to the WebonaryDictionaries collection.

When I did a test the first time I got "es" as the name for Spanish but after I changed it to "Spanish" subsequent uploads seemed to remember. I need to do more testing to confirm this.

If we only need to change the code to a name once when we create the dictionary that's fine but if it is going to revert each time can we create a look-up table or put a field in the options?

@phillip-hopper
Copy link
Collaborator

Use the language name from PHP instead of the one from Flex, whenever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

2 participants