Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nondeterminism strategy code #32

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Fix nondeterminism strategy code #32

merged 2 commits into from
Mar 1, 2022

Conversation

sillydan1
Copy link
Owner

@sillydan1 sillydan1 commented Feb 28, 2022 •
edited
Loading

Fixes

  • PICK_FIRST and PICK_LAST are excactly the same behavior. Even though there's no "order" in an unordered_map, they should still provide different results.
  • PICK_RANDOM would consistently pick one choice if two was available (off-by-one error)
  • CI for windows platforms should compile threaded

@sillydan1 sillydan1 force-pushed the patch/nondet-strategy-bugfix branch from 364e567 to 37f28ea Compare March 1, 2022 06:49
@sillydan1 sillydan1 merged commit 4de9949 into master Mar 1, 2022
@sillydan1 sillydan1 deleted the patch/nondet-strategy-bugfix branch March 1, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sillydan1