Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getGridFieldName in favour of ModelAdmin::sanitiseClassName #19

Closed
robbieaverill opened this issue Jan 29, 2017 · 1 comment
Closed

Remove getGridFieldName in favour of ModelAdmin::sanitiseClassName #19

robbieaverill opened this issue Jan 29, 2017 · 1 comment

Comments

@robbieaverill
Copy link
Contributor

The functionality exists in core, so there's no point in duplicating it.

https://github.com/silverleague/silverstripe-logviewer/blob/master/src/Admin/LogViewerAdmin.php#L79-L82
@robbieaverill
Copy link
Contributor Author

On second thoughts I don't think this is duplication, and I think it's worth keeping it here instead of deprecating the getGridFieldName method and keeping the same logic anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbieaverill