TinyMCE shows empty (useless) formatting options by default

[ScopeyNZ]

Both "Formats" and "Templates" are options in a TinyMCE editor field. This is slightly weird when there are no templates:

But very weird when there are no formats:

This was raised in a content author training and I happened to be sitting next to @clarkepaul at the time. I think the opinion was that we should perhaps provide a default "format" but just not even show "templates" by default. @clarkepaul will have to confirm.

[clarkepaul]

If no Formats exist then the option doesn't need to show at all, no need to provide an example. The same applies for Tiny Templates, if none exist then don't provide the option.

[clarkepaul]

This bloats TinyMCE, as well as seeming broken to users it reflects badly on the CMS.

[muskie9]

Is this still a valid issue? I checked in a fresh install and both templates and format are not showing.

[brynwhyman]

I believe this is specific to CWP, @muskie9. I'm running the latest cwp/cwp 2.3.x-dev (with silverstripe/cms 4.4.x-dev) and this is still an issue:

[muskie9]

Haven't done a whole lot with CWP, but I'll take a peak.

[muskie9]

So as best I can tell, there is an editor.css that is loaded for the Formats from silverstripe/admin: client/dist/styles/editor.css. While that file isn't empty the style just seems to be used if a link is broken (red background). If I add the Simple theme, TinyMCEConfig::getEditorCSS() does include both the admin file as well as the file in the Simple theme. The Simple theme file adds its class to the format dropdown.

This makes me wonder a couple things:

• Why isn't the admin module style loaded to the format dropdown
• Should TinyMCEConfig detect if no other editor.css files are loaded, and if not, remove the format dropdown. I'm not sure if this is actually possible with how things work or if it would have unintended results.

If I get pointed in the right direction on the what and where for this if the latter would be preferred I can dig around a bit and see what I can come up with.

In the mean time, you could probably remove the format dropdown from your installation in an app/_config.php file.

$cwpEditor = \SilverStripe\Forms\HTMLEditor\HTMLEditorConfig::get('cwp');
$cwpEditor->removeButtons('styleselect');