Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search docs should mention that you need BasePageController #202

Open
chillu opened this issue May 31, 2019 · 1 comment
Open

Search docs should mention that you need BasePageController #202

chillu opened this issue May 31, 2019 · 1 comment

Comments

@chillu
Copy link
Member

chillu commented May 31, 2019

Looking at the search docs, there's an expectation that you're using PageController extends BasePageController, which is the default through cwp/installer. BasePage pulls in a lot of stuff that can be unnecessary for CWP projects (e.g. "related pages"), and many CWP devs will remove it from their own inheritance structures.

Which is an issue if you're then following the search docs, because the CWP default search behaviour is configured through:

---
Name: cwpsearchextensions
---
CWP\CWP\PageTypes\BasePageController:
  extensions:
    - CWP\Search\Extensions\SearchControllerExtension

Unless you have this installed, you won't see a search box in your Watea theme. This chain of events is so hard to follow that devs will likely spend hours debugging why their search isn't showing. We should mention that dependency in the CWP search docs.

@robbieaverill
Copy link
Contributor

This chain of events is so hard to follow that devs will likely spend hours debugging why their search isn't showing.

I've done that multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants