Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/build, .env file creation, and other steps are performed when not needed #97

Closed
GuySartorelli opened this issue Jan 28, 2024 · 4 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 28, 2024

Some of our repositories use this CI for convenience, but don't need a running Silverstripe CMS project.

When installer is not included, we shouldn't be setting up a database/etc.

At best this is unnecessary work, at worst it causes failures like https://github.com/creative-commoners/silverstripe-standards/actions/runs/7688362062/job/20949498104

PRs

@emteknetnz
Copy link
Member

@GuySartorelli I left a comment on the merged PR to re-trigger some jobs to check things still work as expected. Once you've validated this close this issue

@GuySartorelli GuySartorelli removed their assignment Jan 29, 2024
@emteknetnz
Copy link
Member

@GuySartorelli Have merged latest PR, please re-run something to validate things still work correctly

@GuySartorelli
Copy link
Member Author

Working as expected now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants