Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't know how to merge up new repositories #28

Closed
GuySartorelli opened this issue Nov 27, 2023 · 3 comments
Closed

Doesn't know how to merge up new repositories #28

GuySartorelli opened this issue Nov 27, 2023 · 3 comments
Assignees
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 27, 2023

Failed merge-up in https://github.com/silverstripe/markdown-php-codesniffer/actions/runs/6973288579/job/18977009246 is due to faulty or missing logic in this action:

PHP Fatal error: Uncaught Exception: Could not work out what the default CMS major version this module uses in /home/runner/work/_actions/silverstripe/gha-merge-up/v1/funcs.php:87
Stack trace:
#0 /home/runner/work/_actions/silverstripe/gha-merge-up/v1/branches.php(9): branches()
#1 {main}
thrown in /home/runner/work/_actions/silverstripe/gha-merge-up/v1/funcs.php on line 87

Acceptance criteria

  • The merge-up action in silverstripe/markdown-php-codesniffer works without errors
  • All new repositories will work without needing a change each time one is added
    OR
  • The instructions for setting up a new repository include whatever steps are necessary to get merge-ups working.

PRs

@GuySartorelli
Copy link
Member Author

@emteknetnz The fragility of merge-ups requiring a specific minimum PHP version should be documented, either in the merge-ups readme or the "adding a new repo" page.

@emteknetnz
Copy link
Member

Done

@GuySartorelli
Copy link
Member Author

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants