Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridField filter doesn't reset the GridField state for pagination links #1573

Closed
rasstislav opened this issue Sep 4, 2023 · 2 comments
Closed

Comments

@rasstislav
Copy link

rasstislav commented Sep 4, 2023

Hello,

I think this is bug.

Description

After canceling the term from the search, the term remains remembered and I cannot reset it.

Steps to reproduce:

  1. Enter the search term and press Enter.
  2. Cancel the search term (eg by clicking the X).
  3. Go to the next page in pagination.

BUG: The search term is returned back.

I am attaching short video.

bug.mov

Acceptance criteria

  • When the search criteria is cleared, you are returned to the first page.
  • When any search criteria is altered, you are returned to the first page.
  • Sorting is unaffected by changing the search term

PRs

@GuySartorelli
Copy link
Member

Yup, definitely a bug. Looks like the gridfield state is still retained after you clear the filters and passed through the pagination links. It's almost certainly related to the changes in silverstripe/silverstripe-framework#10331
Would you like to take a crack at submitting a PR to fix this?

@sabina-talipova
Copy link
Contributor

PRs merged. It will be automatically tagged. Close issue.

@sabina-talipova sabina-talipova removed their assignment Sep 19, 2023
@GuySartorelli GuySartorelli changed the title CMS search box GridField bug GridField filter doesn't reset the GridField state for pagination links Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants