Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant react GridField components #1862

Open
2 tasks
emteknetnz opened this issue Nov 27, 2024 · 0 comments
Open
2 tasks

Remove redundant react GridField components #1862

emteknetnz opened this issue Nov 27, 2024 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 27, 2024

Follow on from #1857 (comment)

GridField.js and probably also GridField*.js files such as GridFieldHeader, GridFieldRow and GridFieldAction, were probably only used by campaign admin

Now that campaign admin has been removed, these components are probably redundant and can be removed

The actual regular gridfield does not have a react component

Acceptance criteria

  • Remove redundant GridField react components if not used elsewhere
  • If they are used elsewhere, remove references to campaigns from the component code
@emteknetnz emteknetnz changed the title Remove dead code Remove redundant react GridField components Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant