Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Saved file' is displayed in History when removed everything from 'Title' and saved #923

Closed
kiran-redhat opened this issue Mar 20, 2019 · 3 comments

Comments

@kiran-redhat
Copy link

kiran-redhat commented Mar 20, 2019

image

Steps to reproduce:

  1. Upload and image and fill with something and save
  2. Empty 'Title' and save the asset
    Expecting to see something like 'Title been removed/emptied' however it says 'Saved file'
@robbieaverill
Copy link
Contributor

@kiran-redhat thanks for raising this issue! Can you please provide the versions of SilverStripe you're using, as well as a clear description of your problem, steps to reproduce and expected behaviour?

@clarkepaul
Copy link
Contributor

I think this might be quite an old version as we no longer have a history on files as a tab like that. I can't recall how much detail we provided in file history but I do remember we tried to explain the change (e.g. title changed). For out newer history we don't explain what the change is, just that its been saved/published with the intention we will introduce more activity detail in the future. Doesn't help much with this issue but you might find that if you update to a newer version you'll loose file history.

@chillu
Copy link
Member

chillu commented Apr 9, 2019

As above, can't reproduce this in 4.3 since there's no history tab. When we're re-introducing this tab, we're most likely doing it by incorporating https://github.com/silverstripe/silverstripe-versioned-snapshots. This changes the way any edits are presented, so we'll have to remember that "change to empty" is a use case. I'll note that on silverstripe/silverstripe-versioned#68

@chillu chillu closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants