Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORM] SiteTree Sort values copied directly to _Live #1544

Closed
frankmullenger opened this issue Jul 13, 2016 · 2 comments
Closed

[ORM] SiteTree Sort values copied directly to _Live #1544

frankmullenger opened this issue Jul 13, 2016 · 2 comments
Labels

Comments

@frankmullenger
Copy link
Contributor

Whenever a page is published the sort order for the sibling pages is published also:
https://github.com/silverstripe/silverstripe-cms/blob/master/code/model/SiteTree.php#L2246

Which leads to issues such as reordering the site tree in draft then publishing one of the sibling pages of the portion of the tree that was reordered.

Discussing with @tractorcow the Sort values could perhaps be a change set that is versioned and published independently. Or perhaps using a float for the Sort value so that pages could be reordered without necessarily a change of the Sort values in other sibling pages.

@tractorcow
Copy link
Contributor

Related to silverstripe/silverstripe-framework#5800

@sminnee sminnee changed the title SiteTree Sort values copied directly to _Live [ORM] SiteTree Sort values copied directly to _Live Oct 8, 2018
@chillu
Copy link
Member

chillu commented Feb 1, 2019

Going to close this in favour of silverstripe/silverstripe-versioned#180

@chillu chillu closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants