Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v4 - Cannot namespace Page and PageController #1911

Closed
WillGibson opened this issue Jul 26, 2017 · 2 comments
Closed

Upgrading to v4 - Cannot namespace Page and PageController #1911

WillGibson opened this issue Jul 26, 2017 · 2 comments

Comments

@WillGibson
Copy link

I'm just starting to experiment with upgrading to version 4 so we can see how close it all seems to being practical to do on our clients' sites.

I namespaced our Page and PageController classes during the upgrade, and this blew it up.

I've un-namespaced them for now, but was wondering if there is a plan to make them namespaceable, or whether the global namespace is still the preferred situation here?

@dhensby
Copy link
Contributor

dhensby commented Jul 26, 2017

please see: silverstripe/silverstripe-framework#5844

@dhensby dhensby closed this as completed Jul 26, 2017
@tractorcow
Copy link
Contributor

Perhaps at ss 5.0 we won't have Page at all, and have a better composability solution for SiteTree along with content blocks and extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants