Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadOne causes page history to break #273

Open
torleif opened this issue Aug 31, 2020 · 2 comments
Open

ReadOne causes page history to break #273

torleif opened this issue Aug 31, 2020 · 2 comments
Labels
affects/v4 complexity/medium impact/high type/bug

Comments

@torleif
Copy link

torleif commented Aug 31, 2020

Page history will break in some page types when using the fix specified here: silverstripe/silverstripe-framework#5844 by putting the Page class in the root namespace.

this is because $this->getDataObjectClass() returns the incorrect data in ReadOne.php in the resolve() function.
@chillu
Copy link
Member

chillu commented Sep 16, 2020

@torleif Is this on GraphQL module v3 or the upcoming v4?

@torleif
Copy link
Author

torleif commented Sep 19, 2020

this is using the stable GraphQL module v3

@chillu chillu removed the v4 label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/high type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@torleif @chillu @emteknetnz