Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback if a page/file link is missing its relation #124

Closed
GuySartorelli opened this issue Nov 30, 2023 · 3 comments
Closed

Provide feedback if a page/file link is missing its relation #124

GuySartorelli opened this issue Nov 30, 2023 · 3 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 30, 2023

Page and file links need a relation to a page or a file so they know what to link to.

There is (or will be) validation to ensure one is provided when the link is first created, but if that related object is later deleted, the link will still exist but will be missing the record it needs to provide a correct link.

There should be some feedback to content authors when such links exist - either in a report, with some visual indicator in the LinkField, or both.

Update: There is now visual feedback in the linkfield itself - so we need to decide if we want this information in a report (e.g. broken links report).

@maxime-rainville
Copy link

maxime-rainville commented Jan 30, 2024

Following discussion with Cassie:

  • This probably has some related concerns with the Broken links #8 card.
  • We should probably aligned the two
    • If we do a broken link reports, links pointing to broken relation should be flag
    • The LinkField should flag any situation where a link should be considered broken (e.g. External link pointing to something that doesn't exist anymore)

Cassie thought we should prioritise this card.

@GuySartorelli
Copy link
Member Author

The LinkField should flag any situation where a link should be considered broken (e.g. External link pointing to something that doesn't exist anymore)

I don't think the linkfield itself should be firing off ajax requests to validate external URLs.

@GuySartorelli
Copy link
Member Author

The display for missing relations is done - the broken link report is a separate issue so this is a duplicate now.
Max is creating another related but separate card about visual feedback for broken links more generally.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants