Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Use proper money math implementation for all calculations #182

Open
bummzack opened this issue Feb 10, 2018 · 0 comments
Open

RFC: Use proper money math implementation for all calculations #182

bummzack opened this issue Feb 10, 2018 · 0 comments
Labels
question RFC
Milestone
3.x

Comments

@bummzack
Copy link
Collaborator

While it's better than using float, I'd like to get rid of our PaymentMath class and use a proper money implementation.

This seems like a really good candidate: https://github.com/moneyphp/money
@bummzack bummzack added this to the 3.x milestone Feb 10, 2018
@bummzack bummzack added the RFC label Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question RFC
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
1 participant
@bummzack