Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnipay gateways that redirect offsite don't necessarily need to call "complete" methods. #186

Open
bummzack opened this issue Feb 14, 2018 · 0 comments

Comments

@bummzack
Copy link
Collaborator

A gateway that redirects offsite doesn't have to implement authorize and purchase in pairs of authorize + completeAuthorize and purchase + completePurchase. It's possible that a Gateway might omit the complete… methods, if there's no data coming back from the offsite request.

Implementation of AuthorizeService and PurchaseService needs to check supportsCompleteAuthorize and supportsCompletePurchase respectively during initiate and complete the action immediately, if the complete… method isn't implmented.

Reference: thephpleague/omnipay-paypal#170 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant