Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing into RealMe loses session data in SilverStripe #165

Open
2 tasks done
torleif opened this issue Sep 20, 2024 · 1 comment
Open
2 tasks done

Signing into RealMe loses session data in SilverStripe #165

torleif opened this issue Sep 20, 2024 · 1 comment

Comments

@torleif
Copy link
Contributor

torleif commented Sep 20, 2024

Module version(s) affected

5.3.2

Description

The default Session variable in SilverStripe 5 has the SameSite=Lax setting enabled.

SameSite Cookie Policy: The SameSite=Lax setting allows cookies to be sent with cross-site GET requests but not POST requests. Since the RealMe return uses a POST request, the session cookie is not sent back, causing the session to reset.

How to reproduce

  1. Create a session variable in your SilverStripe instance.
  2. Sign in to RealMe
  3. Your session will be reset

Possible Solution

Change the default cookie settings, or enable a way to pass through additional data

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@GuySartorelli
Copy link
Member

When you say "Your session will be reset" - what are the actual effects of that? What problems does this cause, specifically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants