Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use phpseclib instead of custom-testing for certificates #20

Open
madmatt opened this issue Apr 30, 2017 · 0 comments
Open

Use phpseclib instead of custom-testing for certificates #20

madmatt opened this issue Apr 30, 2017 · 0 comments
Labels
affects/v4 complexity/medium impact/medium type/enhancement

Comments

@madmatt
Copy link
Member

madmatt commented Apr 30, 2017

@dhensby raised an excellent point on #19 - in RealMeService we're testing for ----- BEGIN to see if it's a certificate that contains a X509 header or not. We could use phpseclib or similar to do this instead, let's do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/medium type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@madmatt @maxime-rainville @emteknetnz @robbieaverill