Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we get a 3.0.0, targeting framework ^4? #68

Open
madmatt opened this issue Sep 11, 2019 · 2 comments
Open

Could we get a 3.0.0, targeting framework ^4? #68

madmatt opened this issue Sep 11, 2019 · 2 comments

Comments

@madmatt
Copy link
Member

madmatt commented Sep 11, 2019

dev-master has some key fixes such as fixes to testsessions that never end (constantly creating new temp databases), among others. There's also one other issue I'm just creating a PR for (where the database created by testsession is immediately cleaned up by TempDatabase when the request ends, meaning that it's useless for Behat testing as it stands without configuration changes).

I know there's been some API changes on master which is why it's targeting ^5, but I've done a quick test changing composer to target framework ^4 and master seems to still work just fine, so would it be possible to get a 3.0.0 with the changes currently on master (plus my PR coming in a sec)?

Happy to help set this up if needed, just wanted to get people's thoughts, at the moment we can't install dev-master unless we also upgrade to framework dev-master and so on down the line.

Thanks!

@madmatt
Copy link
Member Author

madmatt commented Sep 11, 2019

(This is the PR to which I'm referring above: #69 )

@blueo
Copy link
Collaborator

blueo commented Sep 11, 2019

FYI @dnsl48 did some work checking out what would need to change in other modules with the change in master - see #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants