-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
last option is hidden when live search is enabled and list exceeds height of window #1590
Comments
Cannot reproduce. Ubuntu 14.04, Chromium 53.0.2785.143. |
I have this issue since a long time as well. Tried updating the plugin to the newest version and was pretty optimistic that got fixed. |
Please provide a live example. See guidelines for contributing. Bug reportsA bug is a demonstrable problem that is caused by the code in the repository. Guidelines for bug reports:
A good bug report shouldn't leave others needing to chase you up for more Example:
|
I tried to create an example a week ago but wasn't able to build the html structure the bug appears on. If someone has more luck please create such an example. I'll try again if I have some time. |
Ok I got a new idea and here finally is a bug-example: http://plnkr.co/edit/0K7uegP9puwrJ7ZM4Hs7 It turned out it is the css of a template system we use. It was enough to add this to the example. |
I had to find that out.
But I couldnt find the element where div, input and select have one that doesnt fix it. EDIT:
EDIT2: The whole issue in chrome is fixed if you change it to input
|
The function ( |
Thanks for the additional information. Update: |
Adding the below css solved the issue |
This lets the outer absolutely positioned container theoretically spread limitless. Did you test this suggestion? |
@simonberger : I have tested this. You're right those calculation could be removed |
Setting max-height to none works if the select is the only thing on the page. Otherwise, the menu overflows the window, causing an additional unnecessary scrollbar to appear. All of the calculations are necessary. See https://jsfiddle.net/s279o0mp/2/. There's a slight performance hit using input over span, but it's pretty negligible, so I'll switch to that in the next version. |
v1.12.2 has officially been released. |
Able to reproduce in all browsers. When the live search box is added to the outerlist, the innerlist is pushed down and the last option is not accessible.
Adding the following to setSize() for the fix:
searchHeight = this.options.liveSearch ? 30 : 0
'max-height': menuHeight - headerHeight - searchHeight - actionsHeight - doneButtonHeight - menuPadding.vert - searchHeight + 'px',
The text was updated successfully, but these errors were encountered: