horizontally keep in viewport #1016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligns menu to the right border of the element if it doesn't fit in viewport horizontally
|
Hrmm...wouldn't it be better to keep it left aligned if it doesn't fit in the viewport? Then you could at least see the beginning of each option, rather than the end? This might be useful for a right-to-left implementation, though. |
|
You are right, this is for the cases where there is space on the left of the select box, but the right part goes out of the viewport. I'll update the pull request making sure that when there's no space on the left to stay left aligned. |
avantika-gupta-jtg
pushed a commit
to JoshLabs/bootstrap-select
that referenced
this pull request
May 14, 2020
If dropdownAlignRight is set to 'auto', the menu will auto align to the right if there's not enough room to open aligned to the left. close snapappointments#1127, close snapappointments#1016, close snapappointments#1160, close snapappointments#1269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligns menu to the right border of the element if it doesn't fit in viewport
horizontally