Livesearch performance #1631
Merged
Livesearch performance #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2017 16:32
Improves performance by eliminating the need for .parent()
Faster than focus/refocus
|
Looks good! |
|
Sounds great. Could really do with this fix since we have > 1000 items in the picker. Any idea when it might be released? |
|
Would love a release with this fix as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change once again makes significant improvements to the performance of livesearch by eliminating the call to .parent(), this time without breaking keyword searching. See #1606 for more info.
This should also address #1615.
I also made it always scroll to the top of the list when you type. This was previously done by using .focus() on the top item but my last PR removed this for performance reasons (I didn't realise what purpose it was serving). Using .scrollTop() achieves the same result without the performance cost.