Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When doing a develop install, R3F visualisations freeze the browser #67

Closed
loichuder opened this issue Nov 5, 2021 · 3 comments · Fixed by #98
Closed

When doing a develop install, R3F visualisations freeze the browser #67

loichuder opened this issue Nov 5, 2021 · 3 comments · Fixed by #98

Comments

@loichuder
Copy link
Member

Describe the bug

When the extension was installed in "dev mode", it is not possible to display a R3F visualisation: it freezes the browser.

Displaying scalar values, navigating in the file or inspecting entities do not trigger this freeze.

To Reproduce

  1. Install the extension according to https://github.com/silx-kit/jupyterlab-h5web/blob/main/CONTRIBUTING.md#install
  2. Run jupyter lab
  3. Open a HDF file with nD datasets inside
  4. Open a nD dataset
  5. The browser will freeze

Interestingly, this does not happen with a regular installation pip install .

Context

  • Browser: any
  • Version: 1.0.0
  • JupyterLab version: 3

Reported in #48

@loichuder
Copy link
Member Author

loichuder commented Nov 26, 2021

When stopping the script with Firefox, react-reconciler.development.js:15120 gives the following message:

Script terminated by timeout at:
handleError@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:77424:25
renderRootSync@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:77538:18
performSyncWorkOnRoot@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:77125:18
workLoop@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:88424:42
flushWork@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:88397:14
performWorkUntilDeadline@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:88164:48
EventHandlerNonNull*./node_modules/scheduler/cjs/scheduler.development.js/<@http://localhost:8890/lab/extensions/jupyterlab-h5web/static/vendors-node_modules_h5web_app_dist_index_js.645b31f0d2716e7e0dd3.js:88187:3

@loichuder
Copy link
Member Author

The handleError is triggered by a variable ReactDebugCurrentFrame$1 that is undefined.

We seem to be in the following case: facebook/react#14137 (comment)

@loichuder
Copy link
Member Author

Ok so by running jlpm build:prod locally instead of jlpm build, I can have the vis working. I will document this and we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant