Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timeout parameter in OutSim and OutGauge to the connect function #36

Open
mkapal opened this issue Apr 5, 2024 · 0 comments
Open

Comments

@mkapal
Copy link
Member

mkapal commented Apr 5, 2024

It is not clear that the number in the OutSim and OutGauge constructor is the timeout.

const outSim = new OutSim(10000);

The idea is to remove that parameter from the class constructor and define it as an optional parameter of connect().

const outSim = new OutSim();

outSim.connect({
  Host: '127.0.0.1',
  Port: 29999,
  Timeout: 10000,
});
@mkapal mkapal self-assigned this Apr 5, 2024
@mkapal mkapal added enhancement New feature or request breaking change labels Jul 29, 2024
@mkapal mkapal removed the enhancement New feature or request label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant