Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS_MSO TextStart property value is incorrect if player name is included #43

Closed
mkapal opened this issue Jul 16, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working released

Comments

@mkapal
Copy link
Member

mkapal commented Jul 16, 2024

The value of the TextStart property on the IS_MSO packet is incorrect because the message gets converted from LFS encoding into UTF-8, which strips language escape characters.

Solution:

  • Convert the raw player name into UTF-8 (everything before the actual message)
  • Get the length of that string and set that as the TextStart property value

See how it is done in InSim.NET: https://github.com/alexmcbride/insimdotnet/blob/781027af4b06f15c67184bfe33228b64cd15600c/InSimDotNet/Packets/IS_MSO.cs#L81

@mkapal mkapal added the bug Something isn't working label Jul 16, 2024
@mkapal mkapal self-assigned this Jul 16, 2024
@mkapal mkapal changed the title IS_MSO TextStart property value is incorrect IS_MSO TextStart property value is incorrect if player name is included Jul 16, 2024
@mkapal mkapal closed this as completed in 533d107 Jul 16, 2024
Copy link

🎉 This issue has been resolved in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

1 participant