Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older classic TiddlyWikis are not considered "valid" #83

Open
simonbaird opened this issue Mar 9, 2021 · 4 comments
Open

Older classic TiddlyWikis are not considered "valid" #83

simonbaird opened this issue Mar 9, 2021 · 4 comments
Labels
someday Not now but maybe someday

Comments

@simonbaird
Copy link
Collaborator

Some of the methods used to "validate" a TiddlyWiki classic fail for TiddlyWikis older than a certain date.

Not sure what the version is but it's between 2.1.2 and 2.5.0.

This is only an impact for users who upload an old site. Creating a new "classic" site gets you 2.9.2.

The reason is because <script id="versionArea"> doesn't exist.

@simonbaird
Copy link
Collaborator Author

simonbaird commented Mar 10, 2021

This might be a wontfix.

As well as the versionArea differences, there's some more incompatibilities.

Some things I learned about the older classic TiddlyWikis (I'm looking at http://simon.tiddlyspot.com/ FYI).

  1. The tidders themselves are formatted differently:
    <div tiddler="..." ...><pre>
      ...content with line breaks...
    </pre></div>

vs

    <div title="..." ...>...content with escaped line breaks...</div>
  1. There is no div#shadowArea.

1 in particular makes the injection of the ThostUploadPlugin not work. It gets added, but it's not recognized by TiddlyWiki.

We could write some more code to detect the tiddler format, and handle it correctly, but maybe it's not worth the effort.

Effectively we'd need to support three types of TiddlyWiki:

  • TW5
  • "Classic-newer"
  • "Classic-older"

@simonbaird
Copy link
Collaborator Author

simonbaird commented Mar 10, 2021

I'm not sure how much demand there is for supporting TiddlyWikis from 2006 on TiddlyHost.

Perhaps "Classic-older" can remain unsupported.

@simonbaird
Copy link
Collaborator Author

As a workaround, I think probably "Classic newer" supports importing tiddlers from a "Classic older" file. This could be documented, or at least hinted at.

simonbaird added a commit that referenced this issue Mar 12, 2021
..next step would be to support inserting a tiddler with tiddler=
instead of title, and without the pre elemenent.

#83
@simonbaird
Copy link
Collaborator Author

Another blocker to supporting these is that the plugin doesn't work. For example doHttp is not defined. So we'd need an older compatible version of that as well.

simonbaird added a commit that referenced this issue Apr 11, 2021
The old format is from before TW 2.5 or so.

Actually it's not worth it since the thostuploadplugin don't work.
doHttp is not defined.

Probably give up now..
Issue #83
simonbaird added a commit that referenced this issue Apr 11, 2021
The old format is from before TW 2.2 or so.

(Actually this is on hold since I realised the thostuploadplugin won't work.
doHttp is not defined for example.)

Probably give up now..
Issue #83
@simonbaird simonbaird added the someday Not now but maybe someday label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
someday Not now but maybe someday
Projects
None yet
Development

No branches or pull requests

1 participant