Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

allow user to choose between INTERNAL and FILE-IO interface #54

Closed
nathanfranklin opened this issue Mar 30, 2015 · 4 comments · Fixed by #69
Closed

allow user to choose between INTERNAL and FILE-IO interface #54

nathanfranklin opened this issue Mar 30, 2015 · 4 comments · Fixed by #69

Comments

@nathanfranklin
Copy link
Member

No description provided.

@nathanfranklin nathanfranklin added this to the INTERNAL wrapper milestone Mar 30, 2015
@nathanfranklin
Copy link
Member Author

Currently we have:

from simphony.engine import lammps

# defaults to FILE-IO
lammps_md_fileio =  lammps.LammpsWrapper()

# FILE-IO
lammps_md_fileio = LammpsWrapper(interface=lammps.InterfaceType.FILEIO)

#INTERNAL
lammps_md_internal = lammps.LammpsWrapper(interface=lammps.InterfaceType.INTERNAL)

Maybe it would be better to have a simple bool:

from simphony.engine import lammps

# defaults to FILE-IO
lammps_md_fileio =  lammps.LammpsWrapper()

# FILE-IO
lammps_md_fileio = LammpsWrapper(use_internal_interface=False)

#INTERNAL
lammps_md_internal = LammpsWrapper(use_internal_interface=True)

and make the changes suggested in #19

@mehdisadeghi
Copy link
Contributor

I think it depends on how many engines we will have. If there are only FileIO and INTERNAL it makes sense to have a boolean flag to choose one over another, otherwise it is better to define interface type explicitly.

@nathanfranklin
Copy link
Member Author

I think it depends on how many engines we will have. If there are only FileIO and INTERNAL it makes sense to have a boolean flag to choose one over another, otherwise it is better to define interface type explicitly.

I completely agree. As we have only two types (FILE-IO and INTERNAL), I will use the boolean.

@nathanfranklin
Copy link
Member Author

closed by #69

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants