Added a link to the deprecations warning to point to a codemod to help address it #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, I think I'd prefer it if we'd put it in the readme and use the URL property of the deprecation to link to the readme section |
|
forgot to mention: nice work!! |
…p address it The codemod is here: https://github.com/lorcan/test-selectors-codemod
lorcan
force-pushed
the
lorcan/add-link-to-codemod
branch
from
acd747a
to
4bcc432
Compare
|
Great, thanks, I updated the PR. Hope the copy is ok, happy to tweak it 👍 |
|
Cool, is there left to do to get this merged? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, I wrote up a codemod to help address the testSelector deprecation introduced in #134.
The codemod is here: https://github.com/lorcan/test-selectors-codemod
I thought it might be helpful to add a link to the codemod to the deprecation warning in the hopes that it makes it a little easier to fix :-)