Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JSHint with ESLint #33

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Replace JSHint with ESLint #33

merged 2 commits into from
Jan 3, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jan 3, 2017

No description provided.

@Turbo87 Turbo87 requested a review from marcoow January 3, 2017 08:53
@marcoow
Copy link
Member

marcoow commented Jan 3, 2017

Might be good to add https://github.com/DockYard/eslint-plugin-ember-suave ?

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jan 3, 2017

@marcoow yeah, that makes sense in general, but IMHO not in this repo since we don't have any actual Ember code in here.

@marcoow
Copy link
Member

marcoow commented Jan 3, 2017

@marcoow yeah, that makes sense in general, but IMHO not in this repo since we don't have any actual Ember code in here.

Right, good point

@marcoow marcoow merged commit 7368541 into mainmatter:master Jan 3, 2017
@Turbo87 Turbo87 deleted the eslint branch January 3, 2017 09:05
@Turbo87 Turbo87 mentioned this pull request Jan 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @marcoow