Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Babel 6 compatibility #86

Merged
merged 3 commits into from
Mar 27, 2017
Merged

Add Babel 6 compatibility #86

merged 3 commits into from
Mar 27, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Mar 27, 2017

Resolves #77

@Turbo87 Turbo87 changed the title WIP: Add Babel 6 compatibility Add Babel 6 compatibility Mar 27, 2017
@Turbo87 Turbo87 requested a review from marcoow March 27, 2017 19:31
@Turbo87
Copy link
Collaborator Author

Turbo87 commented Mar 27, 2017

/cc @rwjblue

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I also don't know so much about Babel transforms actually.

"test:node": "mocha node-tests",
"test:strip": "STRIP_TEST_SELECTORS=true ember test"
},
"dependencies": {
"ember-cli-babel": "^5.1.7"
"ember-cli-babel": "^5.1.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably bump to ^6.0.0-beta.9 so that the addons own files are compiled with babel 6. That can definitely be done separately though...

@Turbo87 Turbo87 merged commit adab635 into mainmatter:master Mar 27, 2017
@Turbo87 Turbo87 deleted the babel6 branch March 27, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants