Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includesText() alias #31

Merged
merged 3 commits into from
Oct 17, 2017
Merged

Add includesText() alias #31

merged 3 commits into from
Oct 17, 2017

Conversation

Oreoz
Copy link
Contributor

@Oreoz Oreoz commented Oct 16, 2017

Fixes #30.

I did not find tests for other aliases, therefore I didn't write any for this one.

I edited the API.md file manually (EditorConfig had some fun) in order to add mention of the alias. I wasn't sure if it was generated or maintained manually.

- Adds `includesText()` alias for `hasTextContaining()`;
- Adds mention of the alias in API.md;
- EditorConfig trimmed some EOL whitespaces in API.md;
@Turbo87
Copy link
Collaborator

Turbo87 commented Oct 16, 2017

I edited the API.md file manually (EditorConfig had some fun) in order to add mention of the alias. I wasn't sure if it was generated or maintained manually.

you can yarn run docs and it will automatically generate the API.md file :)

@Oreoz
Copy link
Contributor Author

Oreoz commented Oct 16, 2017

There you go! Generated the docs using yarn run docs.

I also took the liberty of adding a minuscule 'Contributing' section in the README to cover stuff I tripped up on. I hope that's alright with you.

@Turbo87
Copy link
Collaborator

Turbo87 commented Oct 17, 2017

awesome, thanks!!

@Turbo87 Turbo87 merged commit 7753bc9 into mainmatter:master Oct 17, 2017
@Turbo87
Copy link
Collaborator

Turbo87 commented Oct 17, 2017

if you want to continue working on this I was thinking that maybe another alias containsText() might also be good, and then we should probably make includesText() the main implementation (due to String.prototype.includes()) and hasTextContaining() an alias to includesText().

@Oreoz
Copy link
Contributor Author

Oreoz commented Oct 17, 2017

Sure thing, if I have some spare time today, I'll look into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants