Adding hasTagName assertion #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I need to add an entry in the ember tests. |
Turbo87
reviewed
Oct 3, 2019
Turbo87
reviewed
Oct 3, 2019
|
@Turbo87 I forget how to make the ember tests work. I added an assertion, but |
|
I believe I figured it out. Added ember test. |
|
I think this PR should be closely followed by |
scalvert
changed the title
Turbo87
approved these changes
Oct 5, 2019
| @@ -18,6 +18,7 @@ module('Acceptance | qunit-dom', function(hooks) { | |||
| assert.dom('#title').exists(); | |||
| assert.dom('#subtitle').doesNotExist(); | |||
| assert.dom('#title').hasText('Welcome to Ember'); | |||
| assert.dom('#title').hasTagName('h2'); | |||
There was a problem hiding this comment.
FWIW we don't have to add all the assertions here. this is just meant as a smoke test that the qunit-dom integration works correctly. the assertions itself are tested enough by the Jest test suite.
Turbo87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #493.