Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint setup #821

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Update eslint setup #821

merged 3 commits into from
Sep 23, 2020

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Sep 23, 2020

  • Update eslint related packages to latest.
  • Remove unneeded --ext setup in package.json script
  • Migrate to using plugin:prettier/recommended
  • Remove override in lib/.eslintrc.js
  • yarn lint --fix

Turbo87
Turbo87 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

just a small merge conflict to resolve now :)

@rwjblue
Update eslint related packages to latest.
f02e270
@rwjblue
Tweak eslint configuration.
f65e627 
* Remove unneeded `--ext` setup in `package.json` script
* Migrate to using `plugin:prettier/recommended`
* Remove override in `lib/.eslintrc.js`
@rwjblue
yarn lint --fix
f57e613
@rwjblue
Copy link
Contributor Author

rwjblue commented Sep 23, 2020

Updated!

@Turbo87 Turbo87 merged commit d5ae59e into mainmatter:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @Turbo87